Skip to content
This repository was archived by the owner on May 6, 2026. It is now read-only.

testing: harden systest teardowns vs transient GCS errors#158

Merged
tseaver merged 2 commits into
googleapis:masterfrom
tseaver:150-tests-harden-systest-teardown
Aug 5, 2020
Merged

testing: harden systest teardowns vs transient GCS errors#158
tseaver merged 2 commits into
googleapis:masterfrom
tseaver:150-tests-harden-systest-teardown

Conversation

@tseaver
Copy link
Copy Markdown
Contributor

@tseaver tseaver commented Aug 5, 2020

Closes #150.

@tseaver tseaver added the testing label Aug 5, 2020
@tseaver tseaver requested review from busunkim96 and plamut August 5, 2020 02:21
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 5, 2020
@tseaver tseaver requested review from cguardia and chrisrossi August 5, 2020 02:22
Copy link
Copy Markdown
Contributor

@plamut plamut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good under the assumption that the changes in noxfile are indeed persistent.

Comment thread noxfile.py
@tseaver tseaver merged commit c98855e into googleapis:master Aug 5, 2020
@tseaver tseaver deleted the 150-tests-harden-systest-teardown branch August 5, 2020 17:26
tritone pushed a commit that referenced this pull request Aug 7, 2020
* refactor: use named consts for session Python versions

Closes #150.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement. testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Testing: harden systest teardowns against 429 / 409 responses.

3 participants